Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation regarding which Identifiers to use in aggregate() #697

Open
conradoplg opened this issue Jul 3, 2024 · 0 comments

Comments

@conradoplg
Copy link
Contributor

For reference, see this comment in Discord

Good question! It shouldn't include the Identifier because that would allow the participant to lie about who they are and evade cheater detection.
The "right way" to do it is for the Coordinator to get the Identifier from an Identity->Identifier mapping that it must keep, which depends on whatever authentication mechanism is used to send messages. For example, if there is an encrypted channel and the participant signs its messages with its private key, then the Coordinator would need a public key -> Identifier mapping and find the the Identifier from the public key being used to verify the participant's message.
(If you don't care about cheater detection, you can disable the "cheater-detection" feature from the crates, and then you can pass an empty map in PublicKeyPackage::verifying_shares... though I've just realized you still have to get identifiers from somewhere in the signature_shares, so we might improve that in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant