Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Workflow for Build and Test #31

Merged
merged 9 commits into from
Jan 3, 2023
Merged

Created Workflow for Build and Test #31

merged 9 commits into from
Jan 3, 2023

Conversation

uzaxirr
Copy link
Member

@uzaxirr uzaxirr commented Jan 1, 2023

Fixes: #16

@uzaxirr uzaxirr added the enhancement New feature or request label Jan 1, 2023
@uzaxirr uzaxirr requested a review from abskrj January 1, 2023 19:39
@uzaxirr uzaxirr self-assigned this Jan 1, 2023
.deepsource.toml Outdated
enabled = true

[analyzers.meta]
import_root = "github.com/uzaxirr/zestream-server"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be zestream or uzaxirr in the url?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file got added up by mistake, will revert this

run: go build -v

- name: Test
run: cd controllers && go test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should test all the tests in service, utils, controllers...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i run go test in root i get

Screenshot 2023-01-02 at 9 08 43 PM

Any idea what modifications are require to run all the unit test present in the project by firing this cmd from the root

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@uzaxirr uzaxirr requested a review from abskrj January 3, 2023 04:41
Copy link
Member

@abskrj abskrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abskrj abskrj merged commit 5d0ce27 into ZeStream:dev Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Github Actions/CI
3 participants