Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes: #24] Added thumbnail function #29

Merged
merged 5 commits into from
Jan 5, 2023
Merged

[Fixes: #24] Added thumbnail function #29

merged 5 commits into from
Jan 5, 2023

Conversation

abskrj
Copy link
Member

@abskrj abskrj commented Jan 1, 2023 •
edited
Loading

  1. Added thumbnail generator function from video file

Fixes #24

@abskrj abskrj force-pushed the feat/thumbnail-generation branch from abebccd to a1d2dba Compare January 1, 2023 17:19
@abskrj abskrj force-pushed the feat/thumbnail-generation branch from a1d2dba to 75a9812 Compare January 3, 2023 18:20
@abskrj abskrj requested a review from uzaxirr January 3, 2023 18:29
@abskrj abskrj marked this pull request as ready for review January 3, 2023 18:30
uzaxirr
uzaxirr reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@uzaxirr uzaxirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think test cases for the changes made in dash.go are missing?

@abskrj
Copy link
Member Author

abskrj commented Jan 4, 2023

will be adding in next PR, having some issue with ffmpreg in test

@abskrj abskrj requested a review from uzaxirr January 4, 2023 16:23
@abskrj abskrj self-assigned this Jan 4, 2023
@abskrj abskrj added the enhancement New feature or request label Jan 4, 2023
uzaxirr
uzaxirr approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@uzaxirr uzaxirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uzaxirr uzaxirr merged commit 1fbfc7b into ZeStream:dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzaxirr uzaxirr uzaxirr approved these changes

Assignees

@abskrj abskrj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate thumbnail from Video and Save it to cloud storage
2 participants
@abskrj @uzaxirr