Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watermark while generating multi-bitrate video #35

Closed
abskrj opened this issue Jan 2, 2023 · 5 comments
Closed

Add watermark while generating multi-bitrate video #35

abskrj opened this issue Jan 2, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@abskrj
Copy link
Member

abskrj commented Jan 2, 2023

Is your feature request related to a problem? Please describe.
We need to have a feature to add watermark to the video while generating the multi-bitrate video. The image will be present in downloads/directory and the filePath will be given, checkout service/dash.go for more details.

Describe the solution you'd like
Image file is present in downloads/ folder, and the (x,y) coordinates will be passed to function, and inject the image in all the bitrate videos at the given bitrate.

@Catalyst-47
Copy link
Contributor

@abhishekraj272 can you please assign this to me?

@abskrj
Copy link
Member Author

abskrj commented Jan 2, 2023

@Catalyst-47 done

@Catalyst-47
Copy link
Contributor

@abhishekraj272
The output generated after running the test file is not playable
Is this expected behaviour?

@abskrj
Copy link
Member Author

abskrj commented Jan 3, 2023

Yes, expected

To test it, copy the path of .mpd file
Google how to play video from network stream in VLC

or just google how to run mpd file in vlc

@Catalyst-47
Copy link
Contributor

got it
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants