-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit inside non-main function #40
Labels
good first issue
Good for newcomers
Comments
I want to work on this |
Hey @Missing-Parallax are you still working on this? If not I'd like to pick this up :) |
Sure Akshat, u can take it.
…On Sat, Jan 7, 2023 at 9:18 PM Akshat Sharma ***@***.***> wrote:
Hey @Missing-Parallax <https://github.com/Missing-Parallax> are you still
working on this? If not I'd like to pick this up :)
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY76OTUMFKWWESDIH4KEGYDWRGF3LANCNFSM6AAAAAATPKLVN4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey @akshat2602 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Packages exposing functions that can stop program execution by exiting are hard to reuse. Program exits in functions other than main() or init() are not encouraged.
Occurrences
There are 4 occurrences of this issue in the repository.
See all occurrences on DeepSource → deepsource.io/gh/ZeStream/zestream-server/issue/RVV-A0003/occurrences/
Solution
calls to
log.Fatal
should be only inmain()
orinit()
functions. So a possible solution for this could be replacinglog.Fatal
with an Error log levelThe text was updated successfully, but these errors were encountered: