Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced fatal logging #56

Merged
merged 3 commits into from
Jan 7, 2023
Merged

Conversation

akshat2602
Copy link
Contributor

@akshat2602 akshat2602 commented Jan 7, 2023

Replaced fatal logging with normal log.Println and returning the error to the controller for further handling.
Haven't added in any log level as the base logger in go has no option for that.
Fixes #40

@akshat2602
Copy link
Contributor Author

While setting up the dev environment I also noticed that some packages are missing from the go.mod file. Specifically the cloud.google.com/go/storage package and github.com/Azure/azure-storage-blob-go package. I think go.mod might've not been committed when these packages were added in for some functionality. Can you please check once? @uzaxirr

@uzaxirr
Copy link
Member

uzaxirr commented Jan 7, 2023

Hey Thanks for the PR
Please checkout this comment #44 (comment)

And let me know if you can do the changes in this PR itself?

Whereas the go.mod file issue is concerned can u create a new issue for it

@akshat2602
Copy link
Contributor Author

And let me know if you can do the changes in this PR itself?

Yeah, sure will make the changes.

Whereas the go.mod file issue is concerned can u create a new issue for it

Yes, will do that and will also issue a PR for that.

@uzaxirr uzaxirr mentioned this pull request Jan 7, 2023
Copy link
Member

@uzaxirr uzaxirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
@abhishekraj272 Can you review it as well?

Copy link
Member

@abskrj abskrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abskrj abskrj merged commit 9f840ac into ZeStream:dev Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit inside non-main function
3 participants