Use of net/http's ListenAndServe function has no support for setting timeouts

[uzaxirr]

Description

HTTP timeouts are necessary to expire inactive connections and failing to do so might make the application vulnerable to attacks like slowloris which work by sending data very slow, which in case of no timeout will keep the connection active eventually leading to a denial-of-service (DoS) attack.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZeStream/zestream-server/issue/GO-S2114/occurrences/

Solution

A possible solution could be

server := &http.Server{
    Addr:         port,
    ReadTimeout:  time.Duration(timeout) * time.Second,
    WriteTimeout: time.Duration(timeout) * time.Second,
}

err := server.ListenAndServe()

[vivek378521]

Have made some changes to the main.go file
Please review: #45

Do suggest if any more changes need to be made @uzaxirr

[vivek378521]

@uzaxirr there was some rebase issue so resolved your comments and created a new PR: #46

Apologies for the older PR. have also attached the test screenshot to the PR

[uzaxirr]

closed via #46