Documentation for cloud storage function #66
Conversation
|
zestream-server/service/consumer.go Line 87 in 038f951 Here, we are storing the Azure container name in constants. Shouldn't we use an env variable for it? @abhishekraj272 @uzaxirr |
|
No, Container name isn't some security key or any much confidential info which could be used to gain access. Such things should be stored in constants i believe. |
|
Right. But does the user set the container name (or it stays the same for every user) or they just provide the credentials? @uzaxirr |
It's customisable, currently it stays the same (the value mentioned in constant) but if someone wants to change for their self-hosted instance they can do so by editing the constant's value in their fork |
|
Alrighty. Then we should not create it as an zestream-server/configs/configs.go Line 34 in 038f951 Shouldn't we have the s3 bucket name and region as constants too? |
|
@Shofiya2003 bucket name and region should be configurable from user side, cos bucket name is unique and people can deploy it on any region so, should be set by user only. Container inside the bucket is generated by the code and can be common on every bucket. Container is just a folder inside the bucket. |
|
Okay |
Added documentation for cloud storage function including details to configure cloud storage accounts.
Closes #47