Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if mempool fee suggestion is not available: do not use 1 sat/vB #2491

Closed
myxmaster opened this issue Oct 24, 2024 · 0 comments · Fixed by #2494
Closed

if mempool fee suggestion is not available: do not use 1 sat/vB #2491

myxmaster opened this issue Oct 24, 2024 · 0 comments · Fixed by #2494

Comments

@myxmaster
Copy link
Contributor

Describe your enhancement idea

In case mempool fee suggestion is enabled but not available (e.g. mempool API down, easy to simulate by editing URL in FeeStore.ts:56), Zeus uses 1 sat/vB (or purge threshold?) which can be very annoying of course.

I found 2 relevant situations where we should improve UI:

  1. Sending on-chain:
  • a warning is displayed 👍
  • user cannot see that a feerate of 1 sat/vB is set 👎
  • if user doesn't click on the warning but just sends, 1 sat/vB is used 👎
  1. Channel opening:
  • no warning is displayed (hidden in 'Advanced settings') 👎
  • user cannot see that a feerate of 1 sat/vB is set 👎
  • If user doesn't click on the warning but just sents, 1 sat/vB is used 👎
  1. Channel closing:
  • a warning is displayed 👍
  • user cannot see that a feerate of 1 sat/vB is set 👎
  • if user doesn't click on the warning but just sends, 1 sat/vB is used 👎

So for channel openings we need to display a warning, and for all cases we should force the user to enter a custom fee rate (disable Send/Open/Close buttons?).

grafik
grafik
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants