Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orb and pad effects not showing on render #311

Open
uHioVK opened this issue Jan 25, 2025 · 1 comment
Open

Orb and pad effects not showing on render #311

uHioVK opened this issue Jan 25, 2025 · 1 comment

Comments

@uHioVK
Copy link

uHioVK commented Jan 25, 2025

including the ring when the player enters an orb's hitbox area, and the solid color circle when the player hits it
they just disappear like "no effects" is checked in the editor
this happens both in the game window and the video
Image

however orb scaling effect remains lol

@uHioVK
Copy link
Author

uHioVK commented Jan 30, 2025

this will only happen when "hide level complete" is enabled
looks like xdBot simply makes all circle effects invisible

// renderer.cpp

class $modify(CCCircleWave) {

    static CCCircleWave* create(float v1, float v2, float v3, bool v4, bool v5) {
        CCCircleWave* ret = CCCircleWave::create(v1, v2, v3, v4, v5);

        if (!Global::get().renderer.recording) return ret;

        if (Mod::get()->getSavedValue<bool>("render_hide_levelcomplete"))
            ret->setVisible(false);

        return ret;
    }

};

fix:

class $modify(CCCircleWave) {

    static CCCircleWave* create(float v1, float v2, float v3, bool v4, bool v5) {
        CCCircleWave* ret = CCCircleWave::create(v1, v2, v3, v4, v5);

        if (!Global::get().renderer.recording || !PlayLayer::get()->m_levelEndAnimationStarted) return ret;

        if (Mod::get()->getSavedValue<bool>("render_hide_levelcomplete"))
            ret->setVisible(false);

        return ret;
    }

};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant