Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about the code based on the paper #48

Open
hayleeXinyi opened this issue Dec 5, 2023 · 1 comment
Open

Confused about the code based on the paper #48

hayleeXinyi opened this issue Dec 5, 2023 · 1 comment

Comments

@hayleeXinyi
Copy link

Thanks for your great work! It is useful and concise, we want to cite your paper. But I have some confusion when I read your paper. Why do you get average at line 91 of persam.py, seeing as how the paper calculates the sim map and then averages it?
target_embedding = target_feat.mean(0).unsqueeze(0)

@ArenaGrenade
Copy link

I think this is just vector math. F_I is taken outside the sum and what remains is the average of the target features they calculate in line 91. The code seems to be correct as far as this is concerned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants