Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken animation in multiplayer - No NBT sync #141

Open
GigaHook opened this issue Oct 22, 2022 · 4 comments
Open

Broken animation in multiplayer - No NBT sync #141

GigaHook opened this issue Oct 22, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@GigaHook
Copy link

Version - 1.18.2
Fabric - 0.14.9
Mod version - 1.4.4
I am using the latest version available

I changed dark katana's parent:weaponAttribute parameter to one-handed(sickle), in singleplayer it works well, but in multiplayer (both LAN and server) the animation is broken. In local server my animation works as it should, but my friend's is broken. From my side I see him holding two katanas with default animation (which shouldn't be). From his side he sees default animation and one katana (while holding second in offhand) while attacking and sees me holding one katana with animation like when I'm using two weapons.
In normal server the situation almost the same (see videos).
I tried lots of weapons with changed attribute, and all of them don't work as they should.

Steps to reproduce the behavior:

  1. Go to multiplayer with someone
  2. Use the command /give @p mcdw:sword_dark_katana{weapon_attributes:'{"parent":"bettercombat:sickle"}'} 2
  3. Take katanas in both hands
  4. Attack
  5. Ask your friend to watch it
  6. See first error from friend's side
  7. Ask friend to attack with these katanas
  8. See second error from your side

Expected behavior
The animation should work the same for every player in multiplayer(sadly it doesn't)

Additional context
Trying to make a recipe to change the animation of a weapon using CraftTweaker.

local multiplayer
What should be

What.should.be.my.side.mp4

How I see my friend

How.I.see.my.friend.mp4

How my friend sees me

How.my.friend.sees.me.mp4

On server

Me

bandicam.2022-10-22.23-25-29-434.mp4

My friend

bandicam.2022-10-22.23-25-02-196.mp4

Me again

bandicam.2022-10-22.23-25-17-685.mp4
@ZsoltMolnarrr ZsoltMolnarrr added the bug Something isn't working label Nov 13, 2022
@ZsoltMolnarrr
Copy link
Owner

It turns out NBT data is not synchronised to other players.
This is an issue of Minecraft itself. I am not sure how to fix it.

@ZsoltMolnarrr ZsoltMolnarrr changed the title Broken animation in multiplayer Broken animation in multiplayer - No NBT sync Nov 24, 2022
@GigaHook
Copy link
Author

It turns out NBT data is not synchronised to other players. This is an issue of Minecraft itself. I am not sure how to fix it.

Oof thats sad. Any chance it's going to be fixed someday?

@ZsoltMolnarrr
Copy link
Owner

I guess there is always a chance. :D I will be looking for solutions, but it might not get fixed very soon.

@GigaHook
Copy link
Author

I guess there is always a chance. :D I will be looking for solutions, but it might not get fixed very soon.

Anyway, I'll try to solve this myself, have some ideas how to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants