-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra line between comments and templ code #351
Remove extra line between comments and templ code #351
Conversation
Your suggestion made it much easier, thank you. |
95c6931
to
cfd8275
Compare
Now looking at the generator's testing part, what would be the alternative for making a new directory, create a |
Thanks for the PR! On the generator testing, I'm not sure I follow what you're looking to test. There's already a test in the CI that ensures that all _templ.go files are up-to-date. |
I meant to add test cases to make sure that the generated comments would also not have that extra line break, for hover docs purpose. It's fine for now, but just to make sure it won't, I think. |
I'm very sorry, but I'm still not understanding the test scenario. If you're going to follow up with some extra tests, brilliant, I'm sure that will explain it more precisely than English can. 😁 |
What's changed?
This PR adds conditions to check if above a Templ block exists comments before appending new line characters.
Fixes #335.
POC
fmt
:fmt
: