Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add an argument to specify if the whole sentence should be linked or only the WordPress/Pressable words should #23

Open
mlaetitia opened this issue Jan 16, 2024 · 0 comments

Comments

@mlaetitia
Copy link

Description

We have so many sites where we only link the WordPress and Pressable words, and we use a sort convoluted way to do this (basically calling do_action twice and adding the rest of the text manually):

esc_html_e( 'All Rights Reserved. Proudly powered by ', 'ttwc' );
do_action(
      'team51_credits',
      array(
	      'wpcom'     => 'WordPress',
	      'pressable' => '',
      )
);
?>.  
<?php
esc_html_e( 'Hosted by ', 'ttwc' );
do_action(
      'team51_credits',
      array(
	      'wpcom'     => '',
	      'pressable' => 'Pressable',
      )
);

Not only this isn't too practical, but also is an issue if we ever need to i18n to languages that change the order of the words in the sentences.

Adding this to the module / plugin would be amazing

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant