Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a Colophon block to the repository #8

Open
jeremyfelt opened this issue Feb 11, 2023 · 4 comments
Open

Consider adding a Colophon block to the repository #8

jeremyfelt opened this issue Feb 11, 2023 · 4 comments

Comments

@jeremyfelt
Copy link

I've implemented a very basic (maybe enough?) version of this in the Illuminate repository.

  1. Shortcodes are not supported in block_template_part(), which we're using—maybe not for much longer—so that we can start to use the site editor for many things, but not all of them.
  2. It'd be nice to see the colophon rendered in the site editor in a nicer way than the shortcode block provides.

I'd be happy to submit an iteration of the Illuminate block to this repo if that makes sense. :)

@katiebethbrown
Copy link
Contributor

Just wanted to +1 the idea of making this a block, since most of our new builds are block themes. It would be a lot easier to setup without having to remember the nuances of the shortcode. 😄

TremiDkhar added a commit to TremiDkhar/colophon that referenced this issue Apr 24, 2024
@TremiDkhar
Copy link

Hello @katiebethbrown,

I agree, we need to create a block for this plugin instead of using a shortcode.

I have added a PR for this. Whenever you are free, please feel free to test it.

@tommusrhodus
Copy link
Contributor

There's a PR here that needs some work: #29

@TremiDkhar
Copy link

Hey @tommusrhodus,

I'll look into the PR sometime around this week.

TremiDkhar added a commit to TremiDkhar/colophon that referenced this issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants