Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO 8859 not detected in this case #31

Open
bpasero opened this issue Mar 29, 2017 · 4 comments
Open

ISO 8859 not detected in this case #31

bpasero opened this issue Mar 29, 2017 · 4 comments

Comments

@bpasero
Copy link
Contributor

bpasero commented Mar 29, 2017

Detect attached file. The result will be windows-1252

iso-8859-1.txt

image

@aadsm
Copy link
Owner

aadsm commented Aug 7, 2017

iso-8859-1 is not currently supported by this library (it could be a todo though). windows-1252 is a superset of iso-8859-1 so it should be fine, what specific problem is this causing?

@demetriusnunes
Copy link

We're also having issues when detecting ISO-8859-1 as windows-1252. We're willing to implement iso-8859-1 support and create a PR for this. Would you point us in the right direction?

@aadsm
Copy link
Owner

aadsm commented Jan 31, 2018

The python version of this library implemented it this way, (https://github.com/chardet/chardet/pull/100/files), so I would probably follow the exact same logic.
There’s only a small range of characters that differs from these two encodings and this change assumes one encoding until it has evidence that this range of characters is being used.

@tahv0
Copy link

tahv0 commented Apr 1, 2019

@demetriusnunes did you make that PR?

Is ISO-8859-1 supported yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants