Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong guess encoding as Windows 1252 #48

Open
Yanpas opened this issue May 19, 2018 · 2 comments
Open

Wrong guess encoding as Windows 1252 #48

Yanpas opened this issue May 19, 2018 · 2 comments

Comments

@Yanpas
Copy link

Yanpas commented May 19, 2018

See microsoft/vscode#33720

Test case

#!/bin/sh

foo() {
	echo "starting …"
}

Ellipsis symbol makes vscode guess cp1252. UTF8 should have higher priority IMO

@Yanpas
Copy link
Author

Yanpas commented Jun 19, 2018

@lingsamuel
Copy link
Contributor

I built vscode-oss with jschardet 2.2.1 and test this case, vscode guess the file as UTF-8 correctly. I think patch #57 and #59 already fixed this issue.
@aadsm maybe this issue can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants