fix: avoid WARNING: there is no transaction in progress

https://jira.railsc.ru/browse/BPC-20518
abak-press · Apr 28, 2022 · ec9deb6 · ec9deb6
1 parent b223770
commit ec9deb6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/treasury/storage/postgre_sql/base.rb b/lib/treasury/storage/postgre_sql/base.rb
@@ -26,8 +26,7 @@ module PostgreSQL
       #
       module Base
         def start_transaction
-          return if transaction_started?
-          return unless connection.transaction_open?
+          return if transaction_started? || connection.transaction_open?
 
           internal_start_transaction
           super

diff --git a/spec/lib/treasury/storage/postgre_sql/db_spec.rb b/spec/lib/treasury/storage/postgre_sql/db_spec.rb
@@ -34,7 +34,6 @@
 
     context 'when shared' do
       it do
-        expect(connection).to receive(:execute).ordered.with('BEGIN')
         expect(connection).to receive(:execute).ordered.with('LOCK TABLE "test_table" IN SHARE MODE')
         expect { storage.lock }.not_to raise_error
       end