Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbsake sieve + --master-data is broken on mariadb10 #78

Closed
abg opened this issue Oct 20, 2014 · 0 comments
Closed

dbsake sieve + --master-data is broken on mariadb10 #78

abg opened this issue Oct 20, 2014 · 0 comments
Assignees
Labels
Milestone

Comments

@abg
Copy link
Owner

abg commented Oct 20, 2014

This probably also affects mysql 5.6 when gtids are used. On MariaDB when --master-data is used, a new section is included:

--
-- GTID to start replication from
--

-- SET GLOBAL gtid_slave_pos='0-1-36509';

This confuses sieve's naive tokenizer / parser which aborts on a silly error like:

# ./dbsake sieve < all_databases.sql.gz > /dev/null
Unable to determine section type at line 25: -- GTID to start replication from

Ultimately the tokenizer needs to be made more robust - similar to issue #69 where this causes issues with compact or other "non-standard" mysqldump formats.

@abg abg added the bug label Oct 20, 2014
@abg abg self-assigned this Jan 8, 2015
abg added a commit that referenced this issue Jan 19, 2015
This changes the directory format to append the MariaDB GTID
section to replication_info.sql[.ext] and otherwise is just
pass through for the stream writer.

Resolves issue #78
@abg abg added this to the dbsake 2.1.0 milestone Jan 29, 2015
@abg abg closed this as completed Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant