Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not clear why ARTBaseMessage.extras returns ARTJsonCompatible #2002

Open
lawrence-forooghian opened this issue Dec 18, 2024 · 0 comments
Open

Not clear why ARTBaseMessage.extras returns ARTJsonCompatible #2002

lawrence-forooghian opened this issue Dec 18, 2024 · 0 comments
Labels
enhancement New feature or improved functionality.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 18, 2024 •
edited by sync-by-unito bot
Loading

From what I can tell, extras is always a JSON object (see TM2i), so I don't know why we have this indirection of ARTJsonCompatible, which requires you to call -toJSON:error: to get a dictionary out of it, and whose API suggests that it might throw even though it won't. Consider changing this type to something that directly represents a JSON object when we do a major release.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the enhancement New feature or improved functionality. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian