Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Deprecations - Implicitly marking parameter $cipherParams as nullable is deprecated #206

Open
alexscott64 opened this issue Dec 18, 2024 · 0 comments

Comments

@alexscott64
Copy link

alexscott64 commented Dec 18, 2024

Hi, I've been running into this issue with PHP 8.4 and Ably sporadically. There is a new deprecation about implicitly marking parameters as nullable.

Right now I'm just seeing it in two spots in my project:

  1. src/Models/BaseMessage.php line 117
  2. src/Models/BaseMessage.php line 141

I've updated my projects and found 99% of the deprecations using the following grep command, not sure if it's helpful for you as well:
grep -Prn --include=\*.php 'function\s+[^(]*\(([^)]*\b(?<!\?)\w[\w\\]*\s+\$\w+\s*=\s*null[^)]*)\)' .

If it's easier, I'd be happy to fix the parameters myself and submit it as a PR, just let me know.

┆Issue is synchronized with this Jira Task by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant