Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to return payload on handle_init error #23

Open
nikitalocalhost opened this issue Dec 1, 2023 · 1 comment · May be fixed by #25
Open

Add an ability to return payload on handle_init error #23

nikitalocalhost opened this issue Dec 1, 2023 · 1 comment · May be fixed by #25

Comments

@nikitalocalhost
Copy link

graphql-ws expects ErrorMessage on error, and Absinthe.GraphqlWS.Message.Error supports providing it, but Absinthe.GraphqlWS.Transport.handle_inbound uses handle_init callback return only as error id.

I think this library has two paths to resolve this:

  1. Add possibility to add payload provided by developer (expect handle_init return something like {:error, {id, payload}, socket})
  2. Generate error inside this library
@nikitalocalhost
Copy link
Author

Stupid patch doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant