Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-8 - Refactor the Landing Page Components #17

Merged
merged 12 commits into from
Jan 27, 2025

Conversation

Musilah
Copy link
Contributor

@Musilah Musilah commented Jan 24, 2025

What type of PR is this?

Thisi is a feature PR

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified features?

Notes

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this:
image
Also font type and size seem to be unchanged.

Signed-off-by: Musilah <[email protected]>
Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see hydration the error and static route notification:
image
image

Also, increase the font size for the content and try the following title:

Simplify Messaging
Empower Systems
Integrate Seamlessly

image

@Musilah
Copy link
Contributor Author

Musilah commented Jan 24, 2025

I still see hydration the error and static route notification: image image

Also, increase the font size for the content and try the following title:

Simplify Messaging
Empower Systems
Integrate Seamlessly

image

I do not see the hydration error on my end but just in case I have ensured that any data to do with dates and math.random() is handled before being used in client side pages.

For the status indicator has also been deactivated.

src/components/section-pricing.tsx Outdated Show resolved Hide resolved
src/components/section-pricing.tsx Outdated Show resolved Hide resolved
src/lib/constants.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. Inline per logical group, also fix typo "inteRgrate"
Simplify Messaging
Empower Systems
Intergrate Seamlessly
  1. The first section should take the whole page height.
  2. Increase font size a bit.

@dborovcanin
Copy link
Contributor

Also, increase the font size in "features" section.

Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
@ianmuchyri
Copy link
Contributor

ianmuchyri commented Jan 27, 2025

Use a top sheet instead of a side one
image
Something like this:
image

function MobileMenu() {
  const [open, setOpen] = useState(false);
  return (
    <Sheet open={open} onOpenChange={setOpen}>
      <SheetTrigger asChild>
        <Button
          className="md:hidden bg-blue-800 hover:bg-blue-600 ml-auto"
          aria-label="Toggle menu"
        >
          <Menu className="h-6 w-6 text-white" />
        </Button>
      </SheetTrigger>
      <SheetContent side="top">
        <Separator className="my-4 mt-8" />
        <nav className="flex flex-col gap-4 mt-8">
          <ul className="flex flex-col space-y-4">
            {navigationLinks.map((link) => (
              <li key={link.label}>
                <Link
                  href={link.href}
                  className="block text-xl text-gray-600 hover:text-blue-600 transition-colors text-center"
                  onClick={() => setOpen(false)}
                >
                  {link.label}
                </Link>
              </li>
            ))}
            <Separator className="my-4" />
            <li className="pt-4">
              <Link href="#pricing">
                <Button
                  variant="default"
                  aria-label="Try for free"
                  className="bg-blue-800 text-white hover:bg-blue-600 px-4 py-4 rounded w-full text-lg"
                >
                  Try For Free
                </Button>
              </Link>
            </li>
          </ul>
        </nav>
      </SheetContent>
    </Sheet>
  );
}

src/components/section-features.tsx Outdated Show resolved Hide resolved
@ianmuchyri
Copy link
Contributor

Let's improve on this footer to make the newsletter a bit bigger
image

Something like this
image

@dborovcanin
Copy link
Contributor

image
Please make this 3 lines:

Simplify Messaging
Empower Systems
Integrate Seamlessly

I.e. keep Messaging in the first line, and don't overflow Seamlessly to the new line.

@dborovcanin dborovcanin merged commit 77e9862 into absmach:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make product page responsive Make topbar sticky Simplify code Move text content to Constants
3 participants