SMQ - 2724 - Add Auth Callout #2731
Open
+566
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
SMQ-2724
branch
3 times, most recently
from
7119d7b to
910f660
Compare
dborovcanin
requested changes
Feb 24, 2025
auth/callback.go
Outdated
Comment on lines
60
to
62
| if len(c.urls) == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Move this to the beginning of the function. Also, let's use a single URL at a time, with other URLs being a fallback, something like https://www.rabbitmq.com/docs/access-control#combined-backends.
rodneyosodo
force-pushed
the
SMQ-2724
branch
3 times, most recently
from
26e4b56 to
c24229d
Compare
SammyOina
requested changes
Feb 25, 2025
arvindh123
requested changes
Feb 25, 2025
arvindh123
requested changes
Feb 25, 2025
rodneyosodo
force-pushed
the
SMQ-2724
branch
from
6d17b81 to
da7fadc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
==========================================
- Coverage 42.21% 34.98% -7.24%
==========================================
Files 348 214 -134
Lines 47813 38057 -9756
==========================================
- Hits 20186 13313 -6873
+ Misses 25424 23665 -1759
+ Partials 2203 1079 -1124 ☔ View full report in Codecov by Sentry. |
rodneyosodo
force-pushed
the
SMQ-2724
branch
3 times, most recently
from
3654abf to
d8699bb
Compare
|
@rodneyosodo Please address comments from @SammyOina and @arvindh123. |
SammyOina
previously approved these changes
Mar 3, 2025
Signed-off-by: Rodney Osodo <[email protected]>
…nt purposes for policy enforcement Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
…ests Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
dborovcanin
reviewed
Mar 3, 2025
| } | ||
|
|
||
| var err error | ||
| for i := range c.urls { |
There was a problem hiding this comment.
Add an explanation comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature pull request that introduces external authorization callouts to the Auth service. It adds new configuration options, a callback mechanism, and integrates it into the authorization flow. The changes include modifications to the service logic, configuration, and testing infrastructure.
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
Yes, I have updated the documentation for the new feature.
Notes
sequenceDiagram participant Client participant AuthService participant CallBack participant ExternalService Client->>AuthService: Request Authorization AuthService->>CallBack: Invoke Authorize(policy) CallBack->>ExternalService: Send HTTP request (GET/POST) ExternalService-->>CallBack: Return response CallBack-->>AuthService: Return authorization result AuthService-->>Client: Respond with result