Update the ModelManager to handle multiple metamodel versions. #986
Conversation
Signed-off-by: Atul_khadse <[email protected]>
Signed-off-by: Atul_khadse <[email protected]>
| * @throws {IllegalModelException} | ||
| * @return {ModelFile} The newly added model file (internal). | ||
| */ | ||
| addModel(ast, cto, fileName, disableValidation) { |
There was a problem hiding this comment.
This would override the addModel in BaseModelManager.
There was a problem hiding this comment.
Thank you for pointing that out! I’ll review it and make sure the base functionality remains unaffected. I think if we want to extend the addModel from BaseModelManager without overriding it completely, we can call the parent method using super.addModel(...) like this
| * @throws {Error} If the version is not supported. | ||
| */ | ||
| validateMetamodelVersion(version) { | ||
| if (!this.metamodelVersions.includes(version)) { |
There was a problem hiding this comment.
Thanks a lot for the PR. But we first need to decide on the strategy how do we support multiple versions of metamodel first and then make relavant changes.
Happy to hear you opinions on the issue discssion board. Thanks!
There was a problem hiding this comment.
@sanketshevkar Thank you for the feedback! That makes sense. I'll share my thoughts on the strategy for supporting multiple metamodel versions on the issue discussion board. Looking forward to collaborating on this further!
Closes #556
Changes
Flags
Related Issues