-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vocabulary support for namespace scoped decorators #983
Open
DibyamAgrawal
wants to merge
15
commits into
accordproject:main
Choose a base branch
from
DibyamAgrawal:dibyam/namespace-vocab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: vocabulary support for namespace scoped decorators #983
DibyamAgrawal
wants to merge
15
commits into
accordproject:main
from
DibyamAgrawal:dibyam/namespace-vocab
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vocManager.addVocabulary(content); | ||
}); | ||
const vocabKeySet=[]; | ||
const namespaceUpdated = newModelManager.getNamespaces().filter(namespace=>namespace!=='[email protected]' && namespace!=='concerto'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this filtering required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the filtering.
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
* chore(aliasing): tests import aliasing Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): add new tests Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): add new tests Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): add new tests Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): upgrade glob to v11 to fix rimraf issue in concerto-types Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): concerto-metamodel bump Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): new test Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): fix test data Signed-off-by: sanketshevkar <[email protected]> --------- Signed-off-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
…ager (accordproject#979) Signed-off-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
0b52413
to
3187ad9
Compare
… dibyam/namespace-vocab Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #858
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname