Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vocabulary support for namespace scoped decorators #983

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

DibyamAgrawal
Copy link
Contributor

@DibyamAgrawal DibyamAgrawal commented Jan 31, 2025

Closes #858

Changes

  • Extract namespace scoped vocabulary from model and create expected yaml
  • Fix Generate DCS for Vocabulary, for namespace terms in yaml
  • Missing term generator generates term for namespace

Flags

  • reusing existing flag "ENABLE_DCS_NAMESPACE_TARGET"

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@DibyamAgrawal DibyamAgrawal changed the title Dibyam/namespace vocab feat: vocabulary support for namespace scoped decorators Jan 31, 2025
@DibyamAgrawal DibyamAgrawal marked this pull request as ready for review February 3, 2025 05:15
@DianaLease DianaLease requested a review from dselman February 5, 2025 13:11
vocManager.addVocabulary(content);
});
const vocabKeySet=[];
const namespaceUpdated = newModelManager.getNamespaces().filter(namespace=>namespace!=='[email protected]' && namespace!=='concerto');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this filtering required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the filtering.

Dibyam-Agrawal and others added 12 commits February 11, 2025 14:14
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
* chore(aliasing): tests import aliasing

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): add new tests

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): add new tests

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): add new tests

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): upgrade glob to v11 to fix rimraf issue in concerto-types

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): update coverage scollection script for globe upgarde

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): update coverage scollection script for globe upgarde

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): update coverage scollection script for globe upgarde

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): update coverage scollection script for globe upgarde

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): concerto-metamodel bump

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): new test

Signed-off-by: sanketshevkar <[email protected]>

* fix(aliasing): fix test data

Signed-off-by: sanketshevkar <[email protected]>

---------

Signed-off-by: sanketshevkar <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: sanketshevkar <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: sanketshevkar <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
… dibyam/namespace-vocab

Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vocabularies don't support namespace-scoped decorators
3 participants