Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mnc2bids] Erroneous "should be a number" warning #1143

Open
maximemulder opened this issue Jul 11, 2024 · 3 comments
Open

[mnc2bids] Erroneous "should be a number" warning #1143

maximemulder opened this issue Jul 11, 2024 · 3 comments
Labels

Comments

@maximemulder
Copy link
Contributor

While trying to convert some dataset to the BIDS format, I encounter the following warning:

WARNING: Cannot compute EffectiveEchoSpacing & TotalReadoutTime for bic_372712_Q1K_dwi_acq_b0_PA_002.mnc
                'dicom_0x0019:el_0x1028' should be a number. Its value is 19.778
                'dicom_0x0051:el_0x100b' should be a number. Its value is 192
                => This is unfortunately the result of a bad dcm2mnc conversion...

This looks obviously wrong. I am on the up-to-date main branch (so this is not the problem fixed by #1127).

@maximemulder
Copy link
Contributor Author

maximemulder commented Jul 11, 2024

Pinging @cmadjar so you get this on your radar.

@cmadjar
Copy link
Collaborator

cmadjar commented Jul 31, 2024

@maximemulder I am confused by should be a number. Its value is 19.778. How can you get a should be a number when the value appears to be a number?

@maximemulder
Copy link
Contributor Author

I haven't looked into it in details yet, but I would bet it probably stores or saves some number as a string somewhere, and when it expects a number, it gets this string and is confused. I guess adding a parseInt / parseFloat somewhere would fix the bug, although if the problem is with dcm2mnc, it would likely better to fix it on their side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants