Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create_timepoint] Success swal appears even on failure #9358

Open
skarya22 opened this issue Sep 24, 2024 · 0 comments
Open

[create_timepoint] Success swal appears even on failure #9358

skarya22 opened this issue Sep 24, 2024 · 0 comments
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@skarya22
Copy link
Contributor

Describe the bug

  • Even when an error occurs, the success swal appears on submit in create_timepoint.

To Reproduce

  1. Break the create_timepoint php code if not already broken. (If [Create_Timepoint] Failure on submit #9357 was merged)
  2. Go to a Access Profile > select a candidate > Create Timepoint
  3. Enter valid information
  4. Press submit
  5. See error

What did you expect to happen?

  • Since there was an error, there should be an error swal, not a success one.
@skarya22 skarya22 added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skarya22