Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create_timepoint] Timepoint creation needs better tests #9362

Open
driusan opened this issue Sep 25, 2024 · 1 comment
Open

[create_timepoint] Timepoint creation needs better tests #9362

driusan opened this issue Sep 25, 2024 · 1 comment
Assignees
@kongtiaowang
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@driusan
Copy link
Collaborator

driusan commented Sep 25, 2024

As pointed out in #9361, tests should have caught the failure of creating a timepoint introduced by #9343 and #9337. There should be more robust tests to ensure it doesn't break in the future.
@driusan driusan added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Sep 25, 2024
@driusan driusan mentioned this issue Sep 25, 2024
Merged
@kongtiaowang
Copy link
Contributor

#9392 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kongtiaowang kongtiaowang

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driusan @kongtiaowang