You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This input seems to be of type 'File' and is optional. So users are able to select one of their own files for it, and the interface will show this selection box:
I noticed the input because in a recent test run of the tool, the user left the input blank, which meant that the tool used the string 'workdir' internally and created such a folder within its task work directory. At the end of processing the CBRAIN logs showed, however, the line:
[2024-11-03 11:13:41 EST] save_results() No cleanup required for pattern '[DIR]'
which is generated by the CBRAIN integration module BoutiquesPostProcessingCleaner.
So my concerns are:
if no value is provided by the user, the 'workdir' value chosen by the tool is not known and the BoutiquesPostProcessingCleaner cannot do its job; this is a minor bug of efficiency.
if the user does provide a value, what happens if the user launches several tasks with the same userfile selected for 'workdir'? All the tasks will start writing to the same workdir at the same time, causing them to corrupt each other; this is a serious bug, this time.
The text was updated successfully, but these errors were encountered:
Also, the description of the input (as shown in the screenshot) should be fixed to provide a better explanation of the meaning of that field, and to fix the grammar.
The ScrnaBox tool has a input with id 'dir', as described in the Boutiques descriptor:
cbrain-plugins-genetics/boutiques_descriptors/scrnabox_1.53.01.json
Line 15 in 3055c2a
This input seems to be of type 'File' and is optional. So users are able to select one of their own files for it, and the interface will show this selection box:
I noticed the input because in a recent test run of the tool, the user left the input blank, which meant that the tool used the string 'workdir' internally and created such a folder within its task work directory. At the end of processing the CBRAIN logs showed, however, the line:
which is generated by the CBRAIN integration module
BoutiquesPostProcessingCleaner
.So my concerns are:
if no value is provided by the user, the 'workdir' value chosen by the tool is not known and the BoutiquesPostProcessingCleaner cannot do its job; this is a minor bug of efficiency.
if the user does provide a value, what happens if the user launches several tasks with the same userfile selected for 'workdir'? All the tasks will start writing to the same workdir at the same time, causing them to corrupt each other; this is a serious bug, this time.
The text was updated successfully, but these errors were encountered: