Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns about ScrnaBOX input 'dir' (-d) #17

Open
prioux opened this issue Nov 3, 2024 · 1 comment
Open

Concerns about ScrnaBOX input 'dir' (-d) #17

prioux opened this issue Nov 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@prioux
Copy link
Member

prioux commented Nov 3, 2024

The ScrnaBox tool has a input with id 'dir', as described in the Boutiques descriptor:

This input seems to be of type 'File' and is optional. So users are able to select one of their own files for it, and the interface will show this selection box:

Image

I noticed the input because in a recent test run of the tool, the user left the input blank, which meant that the tool used the string 'workdir' internally and created such a folder within its task work directory. At the end of processing the CBRAIN logs showed, however, the line:

[2024-11-03 11:13:41 EST] save_results() No cleanup required for pattern '[DIR]'

which is generated by the CBRAIN integration module BoutiquesPostProcessingCleaner.

So my concerns are:

  1. if no value is provided by the user, the 'workdir' value chosen by the tool is not known and the BoutiquesPostProcessingCleaner cannot do its job; this is a minor bug of efficiency.

  2. if the user does provide a value, what happens if the user launches several tasks with the same userfile selected for 'workdir'? All the tasks will start writing to the same workdir at the same time, causing them to corrupt each other; this is a serious bug, this time.

@prioux prioux added the bug Something isn't working label Nov 3, 2024
@prioux
Copy link
Member Author

prioux commented Nov 3, 2024

Also, the description of the input (as shown in the screenshot) should be fixed to provide a better explanation of the meaning of that field, and to fix the grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants