-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaElement.js upgrade #298
Comments
From MediaElement.js version 3.x and later, the namespace has changed from If we switch to using the new namespace, we can leave legacy styles in the Vanilla theme. So, older versions of the Media component would be still supported by the Vanilla theme. The downside is that custom plugins that extend the Media plugin may break due to the namespace change. However, I think this is the better option. Thoughts? |
How far have you been down either option? |
I've been using the new namespaces |
I think carrying on with the new Are the styles very similar? Do you have any sense of the work required to update the library and keep the legacy css namespace? |
Yeah, that's what I was thinking. They may eventually remove the I'll be looking into the theme styles currently. Just resolved an issue that was blocking me. |
Should we remove Vimeo support since there is a dedicated plugin for Vimeo? This would remove some complexity since froogaloop.js is used solely for Vimeo afaik. |
And anything YouTube related for the same reason. |
Subject of the enhancement
Explore updating the MediaElement.js library. This may also require MediaElement.js plugins as that repo contains features like Speed.
The primary goal is to fix some existing a11y issues like #297 and #232. It is unclear if updating the library will fix those. New features should not be considered as part of this analysis.
MediaElement.js Migration Guide
Your environment
The text was updated successfully, but these errors were encountered: