Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale step prefix & suffix are not read out by the screen reader #211

Closed
joe-allen-89 opened this issue Jul 12, 2024 · 1 comment · Fixed by #212
Closed

Scale step prefix & suffix are not read out by the screen reader #211

joe-allen-89 opened this issue Jul 12, 2024 · 1 comment · Fixed by #212
Assignees
@joe-allen-89
Labels
accessibility bug released

Comments

@joe-allen-89
Copy link
Contributor

Subject of the issue/enhancement/features

The scaleStepPrefix & scaleStepSuffix are currently not read out by the screenreader,

Your environment

  • FW v5.40.3
  • Latest Firefox
  • Windows, NVDA

Steps to reproduce

Create a course with a slider, set the scaleStepPrefix/scaleStepSuffix and navigate through the course using a screenreader/keyboard

Expected behaviour

The scaleStepPrefix/scaleStepSuffix should be read out to ensure screenreader users don't miss any information

Actual behaviour

They are not read out

Screenshots (if you can)
@joe-allen-89 joe-allen-89 self-assigned this Jul 12, 2024
@joe-allen-89 joe-allen-89 moved this from New to Assigned in adapt_framework: The TODO Board Jul 12, 2024
joe-allen-89 added a commit that referenced this issue Jul 12, 2024
@joe-allen-89
Fix: aria-valuetext attribute added to the slider to read out prefix/…
11ea8af 
…suffix (fixes #211)
@joe-allen-89 joe-allen-89 mentioned this issue Jul 12, 2024
Merged
@joe-allen-89 joe-allen-89 linked a pull request Jul 12, 2024 that will close this issue
Fix: aria-valuetext attribute added to the slider to read out scaleStepPrefix/scaleStepSuffix (fixes #211) #212
Merged
@joe-allen-89 joe-allen-89 moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jul 12, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jul 24, 2024
github-actions bot pushed a commit that referenced this issue Jul 24, 2024
@semantic-release-bot
Chore(release): 4.5.6 [skip ci]
407ecfa 
## [4.5.6](v4.5.5...v4.5.6) (2024-07-24)

### Fix

* aria-valuetext attribute added to the slider to read out scaleStepPrefix/scaleStepSuffix (fixes #211) (#212) ([f4f88cc](f4f88cc)), closes [#211](#211) [#212](#212) [#211](#211)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 4.5.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
1 participant
@joe-allen-89