Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trickle + Branching end of page #203

Closed
oliverfoster opened this issue Oct 26, 2023 · 1 comment · Fixed by #204
Closed

Trickle + Branching end of page #203

oliverfoster opened this issue Oct 26, 2023 · 1 comment · Fixed by #204
Assignees

Comments

@oliverfoster
Copy link
Member

Subject of the issue

Where the last page article is branching and trickled, trickle cannot determine that there is an subsequently locked model, which is how it determines if it is currently active.

get isTrickling() {
const isTrickling = Adapt.parentView.model.getAllDescendantModels().some(model => {
return model.get('_isAvailable') && model.get('_isTrickled') && model.get('_isLocked');
});
return isTrickling;
}

This needs to be extended to with a check to see if the article is waiting for additional children and if it contains a waiting trickle button.

@oliverfoster oliverfoster self-assigned this Oct 26, 2023
@oliverfoster oliverfoster moved this from New to Assigned in adapt_framework: The TODO Board Oct 26, 2023
@joe-allen-89 joe-allen-89 moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Nov 6, 2023
github-actions bot pushed a commit that referenced this issue Nov 6, 2023
## [7.0.2](v7.0.1...v7.0.2) (2023-11-06)

### Fix

* Allow trickle on final branching article (fixes #203) (#204) ([6c8ea79](6c8ea79)), closes [#203](#203) [#204](#204)
Copy link

github-actions bot commented Nov 6, 2023

🎉 This issue has been resolved in version 7.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant