Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate button text when locked #207

Closed
swashbuck opened this issue Dec 18, 2023 · 1 comment · Fixed by #214
Closed

Alternate button text when locked #207

swashbuck opened this issue Dec 18, 2023 · 1 comment · Fixed by #214
Assignees
@swashbuck
Labels
enhancement released

Comments

@swashbuck
Copy link
Contributor

Subject of the enhancement

When a Trickle button is locked/disabled, it will show the text from _trickle._button.text (if it exists). A common customization of ours is to use different button text depending on if it is locked or unlocked. For example:

  • Trickle button (locked) - "Please complete the content above"
  • Trickle button (unlocked) - "Click here to continue"

This functionality could be achieved by adding a new property of textLocked to _trickle._button. This would be backwards-compatible since we would not change or remote the text property. We would also want to add ariaLabelLocked and similar properties relating to startText and finalText.
@swashbuck swashbuck self-assigned this Mar 7, 2024
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board Mar 7, 2024
@swashbuck swashbuck mentioned this issue Mar 7, 2024
Merged
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Mar 7, 2024
swashbuck added a commit that referenced this issue Mar 18, 2024
@swashbuck
New: Add option for disabled button text (fixes #207)
6512957
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 18, 2024
github-actions bot pushed a commit that referenced this issue Mar 18, 2024
@semantic-release-bot
Chore(release): 7.2.0 [skip ci]
d228770 
# [7.2.0](v7.1.3...v7.2.0) (2024-03-18)

### New

* Add option for disabled button text (fixes #207) ([6512957](6512957)), closes [#207](#207)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Add option for disabled button text (fixes #207) adaptlearning/adapt-contrib-trickle
1 participant
@swashbuck