ViewModel Scope #35
ViewModel Scope #35
Conversation
viewModelScope is added
| val backgroundJob = scope.async { run(params) } | ||
| scope.launch { onResult(backgroundJob.await()) } |
There was a problem hiding this comment.
do we need to use async{} here? Wouldn't
scope.launch {
val result = run(params)
onResult(result)
}
suffice?
| _loginInProgress.value = true | ||
|
|
||
| val username = username.value ?: return | ||
| val password = password.value ?: return |
There was a problem hiding this comment.
line 31 should be below line 33 & 34 since one of them could return from the function and _loginInProgress.value would hang with true
| nowPlayingMoviesResult.either(::handleFailure, ::postNowPlayingMovieList) | ||
| } | ||
| fetchNowPlayingMoviesUseCase.invoke(viewModelScope, UseCase.None) { | ||
| it.either(::handleFailure, ::postNowPlayingMovieList) |
There was a problem hiding this comment.
postNowPlayingMovieList() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postNowPlayingMovieList()
| popularMoviesResult.either(::handleFailure, ::postPopularMovieList) | ||
| } | ||
| fetchPopularMoviesUseCase.invoke(viewModelScope, UseCase.None) { | ||
| it.either(::handleFailure, ::postPopularMovieList) |
There was a problem hiding this comment.
postPopularMovieList() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postPopularMovieList()
| movieDetailResult.either(::handleFailure, ::postMovieDetail) | ||
| } | ||
| fetchMovieDetailUseCase.invoke(viewModelScope, FetchMovieDetailUseCase.Params(id)) { | ||
| it.either(::handleFailure, ::postMovieDetail) |
There was a problem hiding this comment.
postMovieDetail() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postMovieDetail()
| movieCreditsResult.either(::handleFailure, ::postMovieCredits) | ||
| } | ||
| fetchMovieCreditsUseCase.invoke(viewModelScope, FetchMovieCreditsUseCase.Params(id)) { | ||
| it.either(::handleFailure, ::postMovieCredits) |
There was a problem hiding this comment.
postMovieCredits() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postMovieCredits()
| viewModelScope, | ||
| FetchPersonDetailsUseCase.Params(personId) | ||
| ) { | ||
| it.either(::handleFailure, ::postPersonDetails) |
There was a problem hiding this comment.
postPersonDetails() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postPersonDetails()
| loginStateResult.either(::handleFailure, ::handleLoginStateSuccess) | ||
| } | ||
| getLoginStateUseCase.invoke(viewModelScope, UseCase.None) { | ||
| it.either(::handleFailure, ::handleLoginStateSuccess) |
There was a problem hiding this comment.
handleLoginStateSuccess() calls postLoginState() inside. postLoginState() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postLoginState(). Also, handleLoginStateSuccess() calls updateUserDetails() which is a network operation and switches context with Dispatchers.IO. Using postValue() at postLoginState() would better suit here.
| userDetailsResult.either(::handleFailure, ::postUserDetails) | ||
| } | ||
| fetchUserDetailsUseCase.invoke(viewModelScope, UseCase.None) { | ||
| it.either(::handleFailure, ::postUserDetails) |
There was a problem hiding this comment.
postUserDetails() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postUserDetails()
| viewModelScope, | ||
| MultiSearchUseCase.Params(query) | ||
| ) { | ||
| it.either(::handleSearchFailure, ::postMultiSearchResult) |
There was a problem hiding this comment.
postMultiSearchResult() uses LiveData's setValue() functions which must be called from main thread. Either we need to use postValue() on both LiveDatas we wan't their values to change, or switch context when calling postMultiSearchResult()
| topRatedTvShowsResult.either(::handleFailure, ::postTopRatedTvShows) | ||
| } | ||
| fetchTopRatedTvShowsUseCase.invoke(viewModelScope, UseCase.None) { | ||
| it.either(::handleFailure, ::postTopRatedTvShows) |
There was a problem hiding this comment.
postTopRatedTvShows() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postTopRatedTvShows()
| nowPlayingTvShowsResult.either(::handleFailure, ::postNowPlayingTvShows) | ||
| } | ||
| fetchNowPlayingTvShowsUseCase.invoke(viewModelScope, UseCase.None) { | ||
| it.either(::handleFailure, ::postNowPlayingTvShows) |
There was a problem hiding this comment.
postNowPlayingTvShows() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postNowPlayingTvShows()
| tvShowDetailResult.either(::handleFailure, ::postTvShowDetail) | ||
| } | ||
| fetchTvShowDetailUseCase.invoke(viewModelScope, FetchTvShowDetailUseCase.Params(id)) { | ||
| it.either(::handleFailure, ::postTvShowDetail) |
There was a problem hiding this comment.
postTvShowDetail() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postTvShowDetail()
| tvShowCreditResult.either(::handleFailure, ::postTvShowCredits) | ||
| } | ||
| fetchTvShowCreditsUseCase.invoke(viewModelScope, FetchTvShowCreditsUseCase.Params(id)) { | ||
| it.either(::handleFailure, ::postTvShowCredits) |
There was a problem hiding this comment.
postTvShowCredits() uses LiveData's setValue() function which must be called from main thread. Either we need to use postValue(), or switch context when calling postTvShowCredits()
viewModelScope is added
bgScope and uiScope removed