fix: TextField padding between leadingContent and Label/BasicTextField #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcramer
requested review from
MarinaRomanova and
SimonMarquis
as code owners
MarinaRomanova
previously approved these changes
Aug 3, 2023
|
@spark-ui-bot paparazzi golden images |
soulcramer
force-pushed
the
textfield-fix-padding
branch
from
1634704
to
e580b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes description
We were using the default textfield horizontal spacing (16.dp) when even with leading/trailing content so we now use 8.dp only if there's one.
🤔 Context
As mentioned after a Design Review the spacing was bigger than wanted so we needed to reduce it to the correct value.
📸 Screenshots
Close #582