Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: xml parsing in a lint rule for our custom annotations #917

Open
2 tasks done
kazaky opened this issue Jan 24, 2024 · 1 comment
Open
2 tasks done

[FR]: xml parsing in a lint rule for our custom annotations #917

kazaky opened this issue Jan 24, 2024 · 1 comment
Labels
Enhancement New feature or request Good first issue For a first contributor ✅ Ready All the needed informations are detailed within the ticket to include it in another sprint
Milestone

Comments

@kazaky
Copy link
Contributor

kazaky commented Jan 24, 2024

🕵️ Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem

User would miss spell our custom annotation names like typography large

Describe the solution

building a lint rule that will assert that only supported values are used for our keys

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@soulcramer soulcramer added this to the Backlog milestone Jan 24, 2024
@soulcramer soulcramer added the Enhancement New feature or request label Jan 24, 2024
@SimonMarquis
Copy link
Member

This Lint rule should also detect and warn about unexpected empty annotations, especially for variable inputs:

Given these examples:

    <string name="spark_testing_1">Hi <annotation variable="foo"/></string>
    <string name="spark_testing_2">Hi <annotation variable="foo"></annotation></string>
    <string name="spark_testing_3">Hi <annotation variable="foo"> </annotation></string>
    <string name="spark_testing_4">Hi <annotation variable="foo">!</annotation></string>

only the last two will be able to "replace" the span content.

@SimonMarquis SimonMarquis added the Good first issue For a first contributor label Feb 7, 2024
@thomas-leguellec thomas-leguellec added the ✅ Ready All the needed informations are detailed within the ticket to include it in another sprint label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good first issue For a first contributor ✅ Ready All the needed informations are detailed within the ticket to include it in another sprint
Projects
None yet
Development

No branches or pull requests

4 participants