Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage oci registries #148

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Leverage oci registries #148

merged 3 commits into from
Aug 23, 2024

Conversation

jesusfcr
Copy link
Contributor

@jesusfcr jesusfcr commented Aug 13, 2024 •
edited
Loading

This PR leverages the usage of OCI registries to store charts.

  • Declares the chart dependencies in oci format for the ones available (i.e. bitnami).
    • This is much more efficient as there is no need to access the whole huge bitnami repository.
    • It is not available for localstack.
  • Publishes the vulcan-charts in oci://ghcr.io/adevinta/vulcan-charts/vulcan.
    • This would be the standard way of publishing and we plan to deprecate the helm/chart-releaser-action based one.

@jesusfcr jesusfcr force-pushed the oci branch 2 times, most recently from c840bf7 to f336647 Compare August 13, 2024 10:43
@jesusfcr jesusfcr force-pushed the oci branch 6 times, most recently from 466e1c8 to 61b482b Compare August 13, 2024 12:19
@jesusfcr jesusfcr changed the title Use bitnami oci repository Leverage oci registries Aug 13, 2024
jroimartin
jroimartin approved these changes Aug 22, 2024
View reviewed changes
Copy link

@jroimartin jroimartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusfcr jesusfcr merged commit fd2cf41 into master Aug 23, 2024
4 checks passed
@jesusfcr jesusfcr deleted the oci branch August 23, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jroimartin jroimartin jroimartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusfcr @jroimartin