SITES-28693 - Teaser Component Renders Broken HTML When Title is Empty #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated teaser to only allow image to render links if all other elements are empty (pre-title, title, description, actions), in which case it will unwrap the general link on the teaser content. Fixes #2660
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
=========================================
Coverage 87.14% 87.14%
- Complexity 2697 2698 +1
=========================================
Files 235 235
Lines 7202 7202
Branches 1104 1104
=========================================
Hits 6276 6276
Misses 366 366
Partials 560 560 ☔ View full report in Codecov by Sentry. |
spopescu
reviewed
Feb 14, 2025
bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v2/TeaserImpl.java
Outdated
Show resolved
Hide resolved
* Incorporated PR feedback
|
|
@vladbailescu , it looks like, when image + valid link is set and pre-title, title, description, actions are blank then we still have nested anchors. |
LSantha
reviewed
Feb 19, 2025
| @@ -81,7 +81,8 @@ protected void initImage() { | |||
| overriddenImageResourceProperties.put(Teaser.PN_ACTIONS_ENABLED, Boolean.valueOf(actionsEnabled).toString()); | |||
| overriddenImageResourceProperties.put(PN_ID, String.join(ID_SEPARATOR, this.getId(), IMAGE_ID_PREFIX)); | |||
|
|
|||
| if (StringUtils.isNotEmpty(getTitle()) || getTeaserActions().size() > 0) { | |||
| // Only allow image to render links if all other elements are empty | |||
| if (!(StringUtils.isAllBlank(getTitle(), getPretitle(), getDescription()) && getTeaserActions().isEmpty())) { | |||
There was a problem hiding this comment.
We may need '||' here instead of '&&" as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2660