Behavior of Aria Attributes in the Latest Version of @react-aria/slider #5098
-
|
Hello! I hope you are doing well. I would like to inquire about the latest update of @react-aria/slider. I've noticed that with the latest update, my snapshots are automatically updated, and the aria-describedby and aria-details attributes are added with an empty string value. Is this correct? Shouldn't the attributes be removed if they have empty values? I would like to know if this addition was intentional or if there is a specific reason behind it.
|
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
Can you provide a reproduction? Either in our docs on in a codesandbox? Otherwise, this can sometimes happen if you install multiple copies of our packages. This is fairly common as the package managers are really more focused on node, not browser js. You could try deleting your node modules and package lock and see if that resolves the issue. Or you can use tools like yarn dedupe if it is duplicate copies of our packages. |
Beta Was this translation helpful? Give feedback.
-
|
Hello, Robert! Yes, I'm sharing this demo with the example code they have on their website. :) |
Beta Was this translation helpful? Give feedback.
-
|
Ah, yeah, I see it in our docs as well https://react-spectrum.adobe.com/react-aria/useSlider.html#single-thumb It looks like it broke in this PR #4960 I'll add an issue |
Beta Was this translation helpful? Give feedback.
-
|
Appears to have been fixed at some point #5103 |
Beta Was this translation helpful? Give feedback.
Appears to have been fixed at some point #5103