Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent description of ActionButton #3442

Open
ylazy opened this issue Dec 12, 2024 · 3 comments
Open

Inconsistent description of ActionButton #3442

ylazy opened this issue Dec 12, 2024 · 3 comments
Assignees
Labels
bug Results from a bug in the CSS implementation question Further information is requested

Comments

@ylazy
Copy link

ylazy commented Dec 12, 2024

Hi!

Comparing ActionButton - StaticColor - Selected:

This is captured from Action-button-v8.0.0.xd (Spectrum 1): (s1xd)

image
image

This is captured from the storybook (Spectrum 1): (s1sb)

image
image

This is captured from the storybook (Spectrum 2): (s2sb)

image
image

As you can see, the s1xd and s1sb is different. So which one is correct?
Another question, is s2sb correct, as it seems like an updated version of s1sb (not s1xd)?

I believe there's something wrong here.

Please check this!

Thank you!

@ylazy ylazy added the bug Results from a bug in the CSS implementation label Dec 12, 2024
@castastrophe
Copy link
Collaborator

castastrophe commented Jan 15, 2025

@ylazy Can you provide a link to the Storybook you're referencing?

Looking here: https://opensource.adobe.com/spectrum-css/?path=/docs/components-action-button--docs

I'm not seeing the bug that you highlighted in this issue (for S1).

We also have not published the S2 versions to our website as the migrations are not completed yet. We do have a "foundations" release available in Spectrum Web Components (SWC) that is "Spectrum 2"-ish but does is not expected to fully match design documentation yet. The SWC version adds minor color updates and aligns rounded corners, for example, but does not implement down states or other more specific component migrations.

@castastrophe castastrophe added the question Further information is requested label Jan 15, 2025
@ylazy
Copy link
Author

ylazy commented Jan 16, 2025

@castastrophe
Copy link
Collaborator

@ylazy No worries at all! We provide styles for the web components project. That does look out of sync. I'll look into what version is published to the website and can give you an update on when the latest will be updated there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants