Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Support iPad Mini in sp-tray delivery #4647

Closed
1 task done
Rajdeepc opened this issue Aug 6, 2024 · 0 comments · Fixed by #4656
Closed
1 task done

[Feat]: Support iPad Mini in sp-tray delivery #4647

Rajdeepc opened this issue Aug 6, 2024 · 0 comments · Fixed by #4656

Comments

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Aug 6, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Action menu, Picker, Menu

Description of the requested feature

Currently in iPad Mini 6, in landscape mode the sp-action-menu /sp-picker/ menu appears to be rendered from the bottom like a tray, instead of opening as a sp-menu.
It doesn't happen on IPad Pro or IPad 10 (Can only reproduced it on physical devices or in the Safari IOS Simulator).

Mockups or screenshots

image
image

Implementation notes or ideas

Bug in SWC due to fixed height settings in

'(max-width: 700px) and (hover: none) and (pointer: coarse), (max-height: 700px) and (hover: none) and (pointer: coarse)';

Possible solution:
Horizon approach:
https://git.corp.adobe.com/Horizon/hz/blob/main/platform/common/browser-detection-utils/src/ScreenBreakpoint.ts#L29 (edited)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants