Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Breadcrumbs missing lit dependency in 0.47.0 #4680

Closed
1 task done
rickharris opened this issue Aug 20, 2024 · 0 comments · Fixed by #4681
Closed
1 task done

[Bug]: Breadcrumbs missing lit dependency in 0.47.0 #4680

rickharris opened this issue Aug 20, 2024 · 0 comments · Fixed by #4681

Comments

@rickharris
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

breadcrumbs

Expected behavior

Using @spectrum-web-components/breadcrumbs should declare all of its dependencies in its package.json and not result in any Module Not Found errors when used in client apps and bundlers.

Actual behavior

Getting a compilation when trying to use @spectrum-web-components/breadcrumbs due to lit not being declared as a dependency in the module's package.json.

Cannot find module 'lit/directives/ref.js' from '../../node_modules/@spectrum-web-components/breadcrumbs/src/Breadcrumbs.js

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Add @spectrum-web-components/breadcrumbs as a dependency to an npm-based project
  2. import "@spectrum-web-components/breadcrumbs/sp-breadcrumbs.js"
  3. Compile/run app
  4. See module not found error regarding lit.

Sample code or abstract reproduction which illustrates the problem

No response

Severity

None

Logs taken while reproducing problem

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants