Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Overlay is raised too high on the screen when keyboard is open for tablet device #4936

Open
1 task done
yogeshapps opened this issue Nov 14, 2024 · 6 comments
Open
1 task done
Assignees
Labels
Component: Overlay wontfix This will not be worked on

Comments

@yogeshapps
Copy link

yogeshapps commented Nov 14, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-overlay, sp-popover

Expected behavior

The panel should remain visible to the user and reposition itself based on trigger element position.

Actual behavior

When keyboard is open, overlay is raised too high and user is unable to use the panel

Screenshots

Overlay.Out.of.Viewport.Issue.mov

What browsers are you seeing the problem in?

Firefox, Chrome, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Go to https://studio.webcomponents.dev/edit/eBpFzyndu07XRztVOozf/src/index.ts?p=stories in iPad. I used iPad Air.
  2. Click on Click on Button Popover
  3. Click on Example Textfield
  4. Popover is closed on open of soft keyboard of iPad.

Sample code or abstract reproduction which illustrates the problem

https://studio.webcomponents.dev/edit/eBpFzyndu07XRztVOozf/src/index.ts?p=stories
Created a story of the sample code.

No response

Severity

SEV 1

Logs taken while reproducing problem

No response

@yogeshapps yogeshapps added bug Something isn't working needs jira ticket triage An issue needing triage labels Nov 14, 2024
@TarunAdobe TarunAdobe self-assigned this Nov 20, 2024
@TarunAdobe
Copy link
Contributor

Hey @yogeshapps can you create a reproduction of this here so that we can triage it better.

@Rajdeepc
Copy link
Contributor

Hi @yogeshapps Just a friendly reminder: before we begin investigating reported issues, it's essential that the bug reporter follows the bug reporting guidelines. The current ticket is missing important details like repro steps and device diagnostics, which are crucial for efficient triage. Appreciate everyone's effort in keeping the process smooth and efficient!

@yogeshapps
Copy link
Author

Hi @Rajdeepc I have created a story https://studio.webcomponents.dev/edit/eBpFzyndu07XRztVOozf/src/index.ts?p=stories and added steps around this.

@TarunAdobe
Copy link
Contributor

Hello @yogeshapps using type="modal" in the overlay-trigger will solve this issue in ipads. Checkout the updated repro.
Here's the explanation for your future reference.

@najikahalsema najikahalsema added wontfix This will not be worked on Component: Overlay and removed bug Something isn't working triage An issue needing triage needs jira ticket labels Dec 3, 2024
@Rocss
Copy link
Contributor

Rocss commented Dec 4, 2024

@TarunAdobe I don't think using a modal overlay is the proper solution here...
According to documentation, "they should be used when you need to ensure that the user has interacted with the content of the Overlay before continuing with their work" which is not the case in the video.

The type=modal also adds additional functionality such as focus management which I don't think we want here, see related thread: https://adobe.slack.com/archives/CESK60MQD/p1730713316574589

@yogeshapps
Copy link
Author

@Rocss Rightly siad. ColorPicker in Express is of popover type where user can continuously preview there changes without closing it. Popover is the right choice here and not modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Overlay wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants