Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: sp-button-group does not change button sizes based on button group size #5030

Closed
1 task done
lehelen19 opened this issue Jan 16, 2025 · 2 comments
Closed
1 task done

Comments

@lehelen19
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-button-group

Expected behavior

Buttons inside of a button group should change their size based on the button group's size.

Actual behavior

Buttons inside of a button group do not react to the change in button group size.

Screenshots

No response

What browsers are you seeing the problem in?

Chrome, Firefox, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/button-group/
  2. Add "size=l" to a button group on the page
  3. Observe the sizes of the buttons not changing

Sample code or abstract reproduction which illustrates the problem

No response

Severity

None

Logs taken while reproducing problem

No response

@lehelen19 lehelen19 added bug Something isn't working needs jira ticket triage An issue needing triage labels Jan 16, 2025
@lehelen19
Copy link
Contributor Author

There is evidence sp-button-group is intended to change its slotted button sizes based on the button group size with this function; the issue is that it doesn't change when the size property gets updated. One solution would be to introduce an updated() that runs this method when the size changes.

@najikahalsema
Copy link
Collaborator

fixed by #5037

@najikahalsema najikahalsema added Component: Button Group and removed triage An issue needing triage labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants