Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine config issue believed to be causing JDK8 failures in these tests: SSLEngineExplorerMatchedSNI.java & SSLConfigFilePermissionTest.sh #3684

Closed
adamfarley opened this issue Aug 1, 2024 · 8 comments · Fixed by adoptium/aqa-tests#5761
Assignees
Labels

Comments

@adamfarley
Copy link
Contributor

Summary

Please fix machine config issue causing 2 SSL test failures for JDK8.

Details

Original comment quote from Shelley Lambert in recent retrospective:
x64 Solaris: 2 SSL testcase failures, javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java & sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh suspect due to new machine config, consider non-blocking

@sxa
Copy link
Member

sxa commented Nov 5, 2024

Maybe unsupported on solaris - needs a bit more investigation - potentially also excluded

@sxa sxa added this to the 2024-11 (November) milestone Nov 5, 2024
@sxa sxa removed this from Adoptium Backlog Nov 5, 2024
@steelhead31 steelhead31 moved this from Todo to In Progress in 2024 4Q Adoptium Plan Nov 18, 2024
@steelhead31
Copy link
Contributor

SSL handshake test appears to be a known bug with a backport in progress.. https://bugs.openjdk.org/browse/JDK-8212096  , suggest excluding temporarily

@steelhead31
Copy link
Contributor

steelhead31 commented Nov 19, 2024

sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh is being created without execute permissions causing the test to fail...

Fixing the permissions solves this, : https://ci.adoptium.net/job/Grinder/11498/console

@jiekang
Copy link

jiekang commented Nov 19, 2024

SSLConfigFilePermissionTest is a Shell test intended to be run by jtreg via action line

# @run shell SSLConfigFilePermissionTest.sh

This is supposed to use the Bourne Shell to execute the test and the shell scripts are not intended to be executed directly. Maybe this is not working properly for Solaris?

You can see the jtreg spec here: https://openjdk.org/jtreg/tag-spec.html See notes on Action Tags and Action Types

Earlier in the spec it mentions "Note that shell tests should not contain "#!/bin/sh" on the first line; they are intended to be run only via explicit invocation of a shell."

@jiekang
Copy link

jiekang commented Nov 19, 2024

Note that jtreg is a separate project from the jdk and is here: https://github.com/openjdk/jtreg

@steelhead31
Copy link
Contributor

Having discussed further, a fix in compile.sh in aqa repo, specifically for solaris seems like the path of least resistance, I'll also add the other test to excludes with a link to the above, for re-adding at a future date.

@steelhead31
Copy link
Contributor

Need to make upstream fix for script permission/execution problem, solaris test exclude here: adoptium/aqa-tests#5761

@steelhead31 steelhead31 moved this from In Progress to Paused/Blocked in 2024 4Q Adoptium Plan Nov 20, 2024
@steelhead31
Copy link
Contributor

The sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh test is now passing without interventions, on the same machine, with zero changes... https://ci.adoptium.net/job/Grinder/11593/console

@github-project-automation github-project-automation bot moved this from Paused/Blocked to Done in 2024 4Q Adoptium Plan Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants