-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out contents of openjdk-build into openjdk-build and openjdk-build-farm #1108
Comments
I'm not yet convinced by this. If you take the scenario where someone wants to setup up a build system and run our builds then some of the details (the environment files) are only invoked when you run our build-farm scripts. Separating these out into another repository would currently make that use case unnecessarily complex by introducing another repository into the mix. |
Certainly things like the git-hg scripts can be pulled out IMO |
@sxa555 When I tried to use the scripts last time for building java8, the gradle complains that java used there (zulu-7) is too old - it needs jdk8. So IMHO those code should be kept separate. |
If there is no appetite for continuing this discussion, should it and #913 be closed? |
This one should stay - it needs to get done |
@karianna I noticed that the roadmap doesn't mention the build farm at all. And it also appears that the build-farm is to stay in this repo. If that is true, can we close this issue (and if not, does the doc need updating?) |
The build farm should get split out - I've updated the doc accordingly. |
This seems to have been added to the doc since I last saw it. What's the driving reason for splitting out those two? To my mind that adds extra complexity with no significantly visible benefit. Is it part of a larger plan somewhere - I feel that needs more discussoin/justification (Particularly given the problems we've had with the pipelines split)? |
This is making sure there's a clean split between what configuration we use for the Eclipse Adoptium/Temurin build farm vs. pipeline scripts that anyone can utilize. It's another important separation of concerns step to make sure that we're truly serving the needs for the vendors or folks who might run this within their orgs. On balance it maybe that all we need to do is refactor the pipeline scripts so that adopt values are set as defaults and can be overridden. Will need some investigation. I've updated the doc again accordingly. |
The build farm code should be kept separate from the code used to actually build openjdk for folks at home.
The text was updated successfully, but these errors were encountered: