feat(): removed panicking code #293
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christiantyemele
requested review from
Hermann-Core,
IngridPuppet and
Blindspot22
Christiantyemele
requested review from
ndefokou,
Tekum-Emmanuella and
chendiblessing
Hermann-Core
requested changes
Jan 17, 2025
Comment on lines
123
to
124
| error!("Failed to unpack message: {}", err.kind()); | ||
| let response = (StatusCode::BAD_REQUEST, Error::UnpackingError.json()); |
There was a problem hiding this comment.
We should find a better way to handle the kinds of errors that can happen here.
There was a problem hiding this comment.
i think its better this way
There was a problem hiding this comment.
The error kind doesn’t provide sufficient information about the error. We also need additional context to fully understand the error. That’s why a complete error backtrace is necessary.
I need to investigate further to determine why the code panics at this level, as it doesn’t seem to be normal.
There was a problem hiding this comment.
I'm interested in knowing the result of @Hermann-Core's investigation. Please consider his final approval as mine on this PR.
IngridPuppet
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.