limit number of retries #1082
Open
limit number of retries #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbaseman
requested changes
Feb 2, 2025
There was a problem hiding this comment.
The man page should be updated to reflect this new option.
Overall I'm not sure if it is really that useful. On the other hand it doesn't add too much code, so if it helps some users in their setups, why not?
The code should be squashed and rebased, because some other changes have landed on master in the meantime.
| @@ -85,6 +85,7 @@ PPPD_USAGE \ | |||
| " [--user-cert=<file>] [--user-key=<file>]\n" \ | |||
| " [--use-syslog] [--trusted-cert=<digest>]\n" \ | |||
| " [--persistent=<interval>] [-c <file>] [-v|-q]\n" \ | |||
There was a problem hiding this comment.
Shouldn't line 88 replace line 87 here? But maybe the line becomes too long then and should be split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limit number of retries for persistent connections