Fix Coverity defects #1268
Merged
Fix Coverity defects #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CID 456636: Error handling issues (NEGATIVE_RETURNS) "server_fd" is passed to a parameter that cannot be negative. On error, socket() returns -1, not 0!
|
Thanks Dimitri 👍 |
DimitriPapadopoulos
force-pushed
the
coverity_scan_defects
branch
3 times, most recently
from
e2e527a to
ed1202b
Compare
CID 456637: Error handling issues (CHECKED_RETURN) Calling "setsockopt(new_socket, IPPROTO_TCP, 1, &flag, 4U)" without checking return value. This library function may fail and return an error code.
CID 456641: (PRINTF_ARGS) Argument "saml_port" to format specifier "%d" was expected to have type "int" but has type "long".
DimitriPapadopoulos
force-pushed
the
coverity_scan_defects
branch
from
ed1202b to
9d026f1
Compare
warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
|
Not all defects have been fixed. I might look into the rest, time permitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.